topic title: Screenshot 2
Posts: 1,228
secipolla
Joined: 15 Jun 2008
#16
Hi john, here it's overwriting a file with the same name, although I remember maybe the first time it warned about this. But there's many options and I didn't reproduce that again. Also the 'Take another shot' option isn't working.

I admit I didn't test it thoroughly (with all the options) but I'll try to later.
Posts: 1,081
OU812
Joined: 29 Sep 2007
#17
I haven't uploaded a newer version yet since I'm still tweaking so often. I felt that I should wait until I think it's finished before I release an update.

So you have an older version without the error checking. Also, if it's not opening to take another screenshot then there may be a naming problem. Open the script in an editor. At the end of the script is the command to run the script again. Check the filename and make sure it matches the name the script is saved under.

The release may be ready today or tomorrow. When it's ready - or least I think it is - I'll post a screenshot of the screenshot app.

john
Posts: 1,228
secipolla
Joined: 15 Jun 2008
#18
Sorry. I was just running it from the Desktop (double-clicking the file) so of course that option wouldnt work.
Posts: 1,081
OU812
Joined: 29 Sep 2007
#19
Changelog: Added code so that the thumbnail (if chosen) is moved to same directory as the screenshot. The thumbnail also uses the same numbering scheme as the screenshot to avoid accidentally overwriting files.

Here's a screenshot of the screenshot app:


As you can see, I chose the thumbnail option, which is uploaded here (I probably should have gone with 75% instead of 50%).

Also, I was inspired by eriefisher to create another icewm theme by blending the simplestblack window with the korstro taskbar. I like it better than the korstro theme. I now prefer korstro dark to the original korstro.

Also, I am streamlining my menu and taskbar based heavily on spri linux. I am really liking this setup.

The final version of the screenshot app will be available from the link in the first post in this thread. I'm almost positive the bugs have been squashed and the error checking (There is no error checking on the percentage entered for the thumbnail, but that can wait) is good. I like the layout, too. This may be final, or at least a release candidate.

john
Posts: 1,228
secipolla
Joined: 15 Jun 2008
#20
I have another suggestion, John.
You could put a help button on the bottom left corner which would open a file with basic instructions. The ones I find really necessary for first time users are how the 'Window' and 'Custom Area' screenshots work, like:
"To take a screenshot from an application window choose 'Window' in the 'Region to capture' box, set any other desired options, click OK and click on the window to be captured.
To take a screenshot from a partial area of the screen choose 'Custom Area' in the 'Region to capture' box, set any other desired options, click OK, position the mouse pointer at any angle of the area to be captured, click and hold the mouse's left button while dragging toward the opposite angle. While doing so a frame will appear showing the area to be captured. Just let go the mouse button to complete the selection and take the shot."

That's just a sample text.
Posts: 1,081
OU812
Joined: 29 Sep 2007
#21
Thanks. That sounds interesting. I'll give it a shot this weekend.

john
Posts: 1,228
secipolla
Joined: 15 Jun 2008
#22
OTOH, if the delay box is greyed out when in Window or Custom Area mode it won't be so confusing.
Then the help could be in antiX wiki.
Posts: 1,228
secipolla
Joined: 15 Jun 2008
#23
Hi John, to be honest I tested it only now. Congratulations for the excellent design.
My view is that the help is not really necessary.
If it turns out to be simple to implement greying out the delay box when choosing custom or window modes, I think it would be nicer visually and more intuitive.
There's one bug though. When choosing to create a thumbnail it won't do that unless there's already an image with the same name on the output directory. That is, it won't create the thumbnail at the first shot nor if some other shot has a custom name.
I tried to look at the script but it's late and I couldn't find anything (plus I don't know about programming).
I have yet another suggestion: if possible, maybe you could put a sleep command before the 'Keep this screenshot?' dialog. 1 second would do. Most of the times since it pops up before the preview window in ends up hidden.

obs - I translated it already.
Posts: 1,081
OU812
Joined: 29 Sep 2007
#24
Updated screenshot app. Can't remember what I did but I think it's 100%. There's a few things I can't figure out like the greying out of the delay field. It seems to only work in conjunction with the checkbox. Anyway, test it out. I think this is the version that's on the latest test iso.

john
Posts: 1,228
secipolla
Joined: 15 Jun 2008
#25
John, I downloaded this latest version but it still has the same bug.
Do this to see:
run antixscreenshot5, uncheck 'choose the directory' (that doesn't make any difference in the result, it's just to make it more simple), leave 'screenshot' as the name, check 'take another shot' and the thumbnail. You will see that it doesn't create the thumbnail.
now take another shot exactly the same way. It will be forced to create a new name for the files (in this case screenshot_1*). Then the thumbnail creation works.
now take yet another shot with the same settings except the name. Change it for,say 'default'. You will see that it will miss the creation of the thumbnail again. If you take yet one more shot leaving the name 'default' it will again be forced to create a new name and then the thumbnail will be properly created.

As for the dialog 'Keep this screenshot?' it's appearing over the preview window as it should. Don't know if you tweaked something or if it's an effect of me testing in a different antiX installation from yesterday.
Posts: 1,081
OU812
Joined: 29 Sep 2007
#26
Thanks for the clarification. I reproduced the bug. I'll have to do some debugging on it. Perhaps I'll have it ready this weekend.

john
Posts: 1,081
OU812
Joined: 29 Sep 2007
#27
Bug fix:

In the function that"saves" the screenshot (well, actually scrot already saved it in the dir ~/src so the function actually just moves it to your chosen dir), I forgot to write a line of code that moves the thumbnail along with the image. It's fixed and hopefully the bug is squashed. Please test. Thanks.

john
Posts: 1,228
secipolla
Joined: 15 Jun 2008
#28
Seems to be fine now, john.
I'm uploading the ptBR version (anti, if you change the name then it must be changed at the end of the script too for the continuous shots to work).
Posts: 1,228
secipolla
Joined: 15 Jun 2008
#29
Don't want to bloat things but maybe on future versions you could introduce the slider style and put one for the thumbnail percentage and one for the shot quality.
Posts: 1,081
OU812
Joined: 29 Sep 2007
#30
That's trickier than it sounds. I'm having a hard time getting the program to store results from zenity dialogs. Will try some more experiments in later versions...

john